-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace listWeek with listMonth #514
Conversation
@felixhahnweilheim Thanks for the example and PR! @Semir1212 @felixhahnweilheim An extra config option for this is perhaps a bit much. |
I updated the PR to use Old settings (listWeek, listYear) are handled in the
This also sounds interesting. However users might not understand what is happening then. And it is a bit more effort to implement. So I think listMonth is a good solution. (Unless someone wants to spend the time code a good dynamic solution.) |
@luke- @Semir1212 Any news here? I think the monthly list is a good solution now. |
@felixhahnweilheim Sorry for the delay. Sounds good with the Monthly list. Can you please add this change to the Changelog as well? |
Yes, done |
solves #463 by replacing listWeek with
listYearlistMonth.@Semir1212 mentioned two options:
listYearlistMonth (what I did)I think ideally this should be somehow configurable as there are networks with just a few events and those with a lot.
But I would like to bring this issue further because the listWeek view is not practical in my case.
Actually there would be also listMonth which could also be interesting.
With this PR I just want to show how easy this is to solve as the different view modes are already available.